Allon Mureinik has uploaded a new change for review. Change subject: core: ADL - remove redundant null check ......................................................................
core: ADL - remove redundant null check Removed a redundant null check in AuditLogDirector.log. The if branch will occur if auditLogable is null, so the else branch needed double check it - we already know it to be null. Change-Id: I03de66e7494d1b191ad7c71c726bff4aebc570c1 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/11904/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java index d967c6d..30876bb 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java @@ -854,7 +854,7 @@ log.infoFormat(loggerString, resolvedMessage); } } - } else if (auditLogable != null) { + } else { log.infoFormat("No string for {0} type. Use default Log", auditLogable.getAuditLogTypeValue()); } } -- To view, visit http://gerrit.ovirt.org/11904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I03de66e7494d1b191ad7c71c726bff4aebc570c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
