Moti Asayag has posted comments on this change.
Change subject: engine: Preventing running host monitor during activation of
host operation
......................................................................
Patch Set 2: Looks good to me, approved
(3 inline comments)
Minor comments about text
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
Line 54: final VDS vds = getVds();
Line 55: EngineLock monitoringLock =
Line 56: new
EngineLock(Collections.singletonMap(getParameters().getVdsId().toString(),
Line 57: LockingGroup.VDS_INIT.name()), null);
Line 58: log.infoFormat("Before acquiring lock in order to prevent
monitoring for host {0} form pool {1}",
s/form/from ?
s/pool/data-center ?
Line 59: vds.getName(),
Line 60: vds.getstorage_pool_name());
Line 61: getLockManager().acquireLockWait(monitoringLock);
Line 62: log.infoFormat("Lock acquired, from now a monitoring of host
will be skipped for host {0} form pool {1}",
Line 58: log.infoFormat("Before acquiring lock in order to prevent
monitoring for host {0} form pool {1}",
Line 59: vds.getName(),
Line 60: vds.getstorage_pool_name());
Line 61: getLockManager().acquireLockWait(monitoringLock);
Line 62: log.infoFormat("Lock acquired, from now a monitoring of host
will be skipped for host {0} form pool {1}",
s/form/from ?
s/pool/data-center ?
Line 63: vds.getName(),
Line 64: vds.getstorage_pool_name());
Line 65: try {
Line 66:
ExecutionHandler.updateSpecificActionJobCompleted(vds.getId(),
VdcActionType.MaintananceVds, false);
Line 94: });
Line 95: }
Line 96: } finally {
Line 97: getLockManager().releaseLock(monitoringLock);
Line 98: log.infoFormat("Activate finished. Lock released.
Monitoring can run now for host {0} form pool {1}",
s/form/from ?
s/pool/data-center ?
Line 99: vds.getName(),
Line 100: vds.getstorage_pool_name());
Line 101: }
Line 102: }
--
To view, visit http://gerrit.ovirt.org/11885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7f5eed741ca392ed7144934c539d2aa70744431
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
