Kanagaraj M has posted comments on this change.
Change subject: engine: get Up server by cluster query
......................................................................
Patch Set 1: (2 inline comments)
New patch set to follow.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsInUpStatusByVdsGroupIdQuery.java
Line 12: return ClusterUtils.getInstance();
Line 13: }
Line 14:
Line 15: @Override
Line 16: protected void executeQueryCommand() {
just for re-usability. ClusterUtil does some additional things like null check
and i dont want to repeat them.
Line 17:
getQueryReturnValue().setReturnValue(getClusterUtils().getUpServer(getParameters().getId()));
Line 18: }
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsInUpStatusByVdsGroupIdQueryTest.java
Line 67: vds.setvds_group_id(CLUSTER_ID);
Line 68: vds.setstatus(status);
Line 69: return vds;
Line 70: }
Line 71:
Done. It will return null.
Line 72: @Test
Line 73: public void testExecuteQueryCommnad() {
Line 74: getQuery().executeQueryCommand();
Line 75: VDS actual = (VDS)
getQuery().getQueryReturnValue().getReturnValue();
--
To view, visit http://gerrit.ovirt.org/11914
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1699ae4895cce1bfbac01ff59b634b8c99432e42
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
