Roy Golan has uploaded a new change for review.

Change subject: core: [cleanup] make managementIp field a conventional property
......................................................................

core: [cleanup] make managementIp field a conventional property

- rename the the field from 'ip' to managementIp

- fix a typo in getters and setters

Signed-off-by: Roy Golan <[email protected]>
Change-Id: Ieca99ae5bd2eced0a5882a6a6c778370cf16a975
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
M 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M 
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
17 files changed, 41 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/11952/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
index 1bf8c14..8461d48 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
@@ -171,7 +171,7 @@
             // Also gluster peer probe is not needed when importing an 
existing gluster cluster
             if (isGlusterSupportEnabled() && getAllVds(getVdsGroupId()).size() 
> 1) {
                 String hostName =
-                        (getParameters().getvds().getHostName().isEmpty()) ? 
getParameters().getvds().getManagmentIp()
+                        (getParameters().getvds().getHostName().isEmpty()) ? 
getParameters().getvds().getManagementIp()
                                 : getParameters().getvds().getHostName();
                 VDSReturnValue returnValue =
                         runVdsCommand(
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
index 1fc4f42..3a80e19 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
@@ -185,7 +185,7 @@
 
     private boolean glusterHostRemove(Guid sourceClusterId) {
         String hostName =
-                (getVds().getHostName().isEmpty()) ? getVds().getManagmentIp()
+                (getVds().getHostName().isEmpty()) ? getVds().getManagementIp()
                         : getVds().getHostName();
         VDSReturnValue returnValue =
                 runVdsCommand(
@@ -204,7 +204,7 @@
 
     private boolean glusterHostAdd(Guid targetClusterId) {
         String hostName =
-                (getVds().getHostName().isEmpty()) ? getVds().getManagmentIp()
+                (getVds().getHostName().isEmpty()) ? getVds().getManagementIp()
                         : getVds().getHostName();
         VDSReturnValue returnValue =
                 runVdsCommand(
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
index d4d651d..ef995f0 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
@@ -261,7 +261,7 @@
     private String getManagementIp(FenceAgentOrder order) {
         String managementIp = "";
         if (order == FenceAgentOrder.Primary) {
-            managementIp = _vds.getManagmentIp();
+            managementIp = _vds.getManagementIp();
         }
         else if (order == FenceAgentOrder.Secondary) {
             managementIp = _vds.getPmSecondaryIp();
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java
index f6060ba..611b6f6 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java
@@ -24,7 +24,7 @@
         tempVar.setId((Guid) ((id != null) ? id : Guid.Empty));
         tempVar.setStoragePoolId(getParameters().getStoragePoolId());
         if (getParameters().getOrder() == FenceAgentOrder.Primary) {
-        tempVar.setManagmentIp(getParameters().getManagementIp());
+        tempVar.setManagementIp(getParameters().getManagementIp());
         tempVar.setPmOptionsMap(getParameters().getFencingOptions());
         tempVar.setPmType(getParameters().getPmType());
         tempVar.setPmUser(getParameters().getUser());
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
index 9db741e..c26ff19 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
@@ -407,7 +407,7 @@
                                 "VdcBLL::HandleOldVdssWithSameHostName - Could 
not change the IP for an existing VDS. All available hostnames are taken (ID = 
{0}, name = {1}, management IP = {2} , host name = {3})",
                                 vds_byHostName.getId(),
                                 vds_byHostName.getName(),
-                                vds_byHostName.getManagmentIp(),
+                                vds_byHostName.getManagementIp(),
                                 vds_byHostName.getHostName());
                         error = 
AuditLogType.VDS_REGISTER_ERROR_UPDATING_HOST_ALL_TAKEN;
                         returnValue = false;
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java
index 0b040cb..0c271dc 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java
@@ -67,7 +67,7 @@
     private boolean serverExists(List<VDS> serversList, GlusterServerInfo 
glusterServer) {
         for (VDS server : serversList) {
             String serverHostnameOrIp =
-                    server.getHostName().isEmpty() ? server.getManagmentIp() : 
server.getHostName();
+                    server.getHostName().isEmpty() ? server.getManagementIp() 
: server.getHostName();
             if 
(serverHostnameOrIp.equalsIgnoreCase(glusterServer.getHostnameOrIp())) {
                 return true;
             }
diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
index 309cc88..6e530b5 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
@@ -22,8 +22,8 @@
 
     public VdsOperationActionParameters(VdsStatic vdsStatic, String 
rootPassword) {
         super(vdsStatic.getId());
-        if ("".equals(vdsStatic.getManagmentIp())) {
-            vdsStatic.setManagmentIp(null);
+        if ("".equals(vdsStatic.getManagementIp())) {
+            vdsStatic.setManagementIp(null);
         }
         _vdsStatic = vdsStatic;
         _rootPassword = rootPassword;
diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
index 540f03f..ef7eeaa 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
@@ -185,7 +185,7 @@
         this.vdsGroupDescription = vds_group_description;
         this.setId(vds_id);
         this.setVdsName(vds_name);
-        this.setManagmentIp(ip);
+        this.setManagementIp(ip);
         this.setHostName(host_name);
         this.setPort(port);
         this.setStatus(VDSStatus.forValue(status));
@@ -253,7 +253,7 @@
                         getVdsGroupDescription(),
                         Guid.createGuidFromString(getId().toString()),
                         getName(),
-                        getManagmentIp(),
+                        getManagementIp(),
                         getHostName(),
                         getPort(),
                         getStatus().getValue(),
@@ -410,12 +410,12 @@
         this.mVdsStatic.setVdsName(value);
     }
 
-    public String getManagmentIp() {
-        return this.mVdsStatic.getManagmentIp();
+    public String getManagementIp() {
+        return this.mVdsStatic.getManagementIp();
     }
 
-    public void setManagmentIp(String value) {
-        this.mVdsStatic.setManagmentIp(value);
+    public void setManagementIp(String value) {
+        this.mVdsStatic.setManagementIp(value);
     }
 
     public String getUniqueId() {
diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
index 4c4f1d5..5ee01d9 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
@@ -34,7 +34,7 @@
     @HostnameOrIp(message = 
"VALIDATION.VDS.POWER_MGMT.ADDRESS.HOSTNAME_OR_IP", groups = 
PowerManagementCheck.class)
     @NotNull(groups = PowerManagementCheck.class)
     @Size(max = BusinessEntitiesDefinitions.HOST_IP_SIZE)
-    private String ip;
+    private String managementIp;
 
     @HostnameOrIp(message = "VALIDATION.VDS.CONSOLEADDRESSS.HOSTNAME_OR_IP",
             groups = { CreateEntity.class, UpdateEntity.class })
@@ -138,7 +138,7 @@
         serverSslEnabled = false;
         vdsStrength = 100;
         this.hostname = host_name;
-        this.ip = ip;
+        this.managementIp = ip;
         this.uniqueId = uniqueId;
         this.port = port;
         this.vdsGroupId = vds_group_id;
@@ -167,12 +167,12 @@
         this.hostname = value;
     }
 
-    public String getManagmentIp() {
-        return this.ip;
+    public String getManagementIp() {
+        return this.managementIp;
     }
 
-    public void setManagmentIp(String value) {
-        this.ip = value;
+    public void setManagementIp(String value) {
+        this.managementIp = value;
     }
 
     public String getUniqueID() {
@@ -453,7 +453,7 @@
         result = prime * result + ((hostname == null) ? 0 : 
hostname.hashCode());
         result = prime * result + ((consoleAddress == null) ? 0 : 
consoleAddress.hashCode());
         result = prime * result + ((id == null) ? 0 : id.hashCode());
-        result = prime * result + ((ip == null) ? 0 : ip.hashCode());
+        result = prime * result + ((managementIp == null) ? 0 : 
managementIp.hashCode());
         result = prime * result + ((name == null) ? 0 : name.hashCode());
         result = prime * result + (int) (otpValidity ^ (otpValidity >>> 32));
         result = prime * result + (pmEnabled ? 1231 : 1237);
@@ -463,7 +463,7 @@
         result = prime * result + ((pmPort == null) ? 0 : pmPort.hashCode());
         result = prime * result + ((pmType == null) ? 0 : pmType.hashCode());
         result = prime * result + ((pmUser == null) ? 0 : pmUser.hashCode());
-        result = prime * result + ((pmSecondaryIp == null) ? 0 : 
ip.hashCode());
+        result = prime * result + ((pmSecondaryIp == null) ? 0 : 
managementIp.hashCode());
         result = prime * result + (pmSecondaryConcurrent ? 1231 : 1237);
         result = prime * result + ((pmSecondaryOptions == null) ? 0 : 
pmOptions.hashCode());
         result = prime * result + ((pmSecondaryOptionsMap == null) ? 0 : 
pmSecondaryOptionsMap.hashCode());
@@ -504,10 +504,10 @@
                 return false;
         } else if (!id.equals(other.id))
             return false;
-        if (ip == null) {
-            if (other.ip != null)
+        if (managementIp == null) {
+            if (other.managementIp != null)
                 return false;
-        } else if (!ip.equals(other.ip))
+        } else if (!managementIp.equals(other.managementIp))
             return false;
         if (name == null) {
             if (other.name != null)
diff --git 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
index 68591cd..c585764 100644
--- 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
+++ 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
@@ -211,7 +211,7 @@
             entity.setVdsGroupDescription(rs
                     .getString("vds_group_description"));
             entity.setVdsName(rs.getString("vds_name"));
-            entity.setManagmentIp(rs.getString("ip"));
+            entity.setManagementIp(rs.getString("ip"));
             entity.setUniqueId(rs.getString("vds_unique_id"));
             entity.setServerSslEnabled(rs
                     .getBoolean("server_SSL_enabled"));
diff --git 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
index 0c1a537..2a28bce 100644
--- 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
+++ 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
@@ -77,7 +77,7 @@
     private MapSqlParameterSource getInsertOrUpdateParams(final VdsStatic vds) 
{
         return getCustomMapSqlParameterSource()
                 .addValue("host_name", vds.getHostName())
-                .addValue("ip", vds.getManagmentIp())
+                .addValue("ip", vds.getManagementIp())
                 .addValue("vds_unique_id", vds.getUniqueID())
                 .addValue("port", vds.getPort())
                 .addValue("vds_group_id", vds.getVdsGroupId())
@@ -125,7 +125,7 @@
                 throws SQLException {
             VdsStatic entity = new VdsStatic();
             entity.setHostName(rs.getString("host_name"));
-            entity.setManagmentIp(rs.getString("ip"));
+            entity.setManagementIp(rs.getString("ip"));
             entity.setUniqueID(rs.getString("vds_unique_id"));
             entity.setPort(rs.getInt("port"));
             entity.setVdsGroupId(Guid.createGuidFromString(rs
diff --git 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
index 5f27b53..1fe90a3 100644
--- 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
+++ 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
@@ -98,7 +98,7 @@
             entity.setPmEnabled(model.isEnabled());
         }
         if (model.isSetAddress()) {
-            entity.setManagmentIp(model.getAddress());
+            entity.setManagementIp(model.getAddress());
         }
         if (model.isSetUsername()) {
             entity.setPmUser(model.getUsername());
@@ -133,7 +133,7 @@
                         entity.setPmType(agent.getType());
                     }
                     if (agent.isSetAddress()) {
-                        entity.setManagmentIp(agent.getAddress());
+                        entity.setManagementIp(agent.getAddress());
                     }
                     if (agent.isSetUsername()) {
                         entity.setPmUser(agent.getUsername());
@@ -344,7 +344,7 @@
         PowerManagement model = template != null ? template : new 
PowerManagement();
         model.setType(entity.getPmType());
         model.setEnabled(entity.getpm_enabled());
-        model.setAddress(entity.getManagmentIp());
+        model.setAddress(entity.getManagementIp());
         model.setUsername(entity.getPmUser());
         if (entity.getPmOptionsMap() != null) {
             model.setOptions(map(entity.getPmOptionsMap(), null));
@@ -362,9 +362,9 @@
         if (entity.getpm_enabled()) {
             // Set Primary Agent
             Agent agent = new Agent();
-            if (!StringUtils.isEmpty(entity.getManagmentIp())) {
+            if (!StringUtils.isEmpty(entity.getManagementIp())) {
                 agent.setType(entity.getPmType());
-                agent.setAddress(entity.getManagmentIp());
+                agent.setAddress(entity.getManagementIp());
                 agent.setUsername(entity.getPmUser());
                 if (entity.getPmOptionsMap() != null) {
                     agent.setOptions(map(entity.getPmOptionsMap(), null));
diff --git 
a/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
 
b/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
index 02a5d50..72d9949 100644
--- 
a/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
+++ 
b/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
@@ -156,7 +156,7 @@
         VDS vds = new VDS();
         vds.setId(Guid.Empty);
         vds.setpm_enabled(true);
-        vds.setManagmentIp(ip[0]);
+        vds.setManagementIp(ip[0]);
         vds.setPmType("apc");
         vds.setPmUser("user");
         vds.setPmOptions("secure=true");
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
index 419c2cc..7b08250 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
@@ -205,13 +205,13 @@
 
         obj.setHostName(instance.getHostName());
 
-        obj.setManagmentIp(instance.getManagmentIp());
+        obj.setManagementIp(instance.getManagementIp());
         obj.setPmUser(instance.getPmUser());
         obj.setPmPassword(instance.getPmPassword());
         obj.setPmType(instance.getPmType());
         obj.setPmOptionsMap(instance.getPmOptionsMap());
 
-        obj.setPmSecondaryIp(instance.getManagmentIp());
+        obj.setPmSecondaryIp(instance.getManagementIp());
         obj.setPmSecondaryUser(instance.getPmUser());
         obj.setPmSecondaryPassword(instance.getPmPassword());
         obj.setPmSecondaryType(instance.getPmType());
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
index bbc9e77..d8c5835 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
@@ -443,7 +443,7 @@
         host.setVdsSpmPriority(model.getSpmPriorityValue());
 
         // Save primary PM parameters.
-        host.setManagmentIp((String) model.getManagementIp().getEntity());
+        host.setManagementIp((String) model.getManagementIp().getEntity());
         host.setPmUser((String) model.getPmUserName().getEntity());
         host.setPmPassword((String) model.getPmPassword().getEntity());
         host.setPmType((String) model.getPmType().getSelectedItem());
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
index 5e6c671..89b9856 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
@@ -1607,7 +1607,7 @@
         host.setVdsSpmPriority(model.getSpmPriorityValue());
 
         // Save primary PM parameters.
-        host.setManagmentIp((String) model.getManagementIp().getEntity());
+        host.setManagementIp((String) model.getManagementIp().getEntity());
         host.setPmUser((String) model.getPmUserName().getEntity());
         host.setPmPassword((String) model.getPmPassword().getEntity());
         host.setPmType((String) model.getPmType().getSelectedItem());
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
index 27d9d32..b800e16 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
@@ -804,7 +804,7 @@
         host.setPmProxyPreferences(model.getPmProxyPreferences());
 
         // Save primary PM parameters.
-        host.setManagmentIp((String) model.getManagementIp().getEntity());
+        host.setManagementIp((String) model.getManagementIp().getEntity());
         host.setPmUser((String) model.getPmUserName().getEntity());
         host.setPmPassword((String) model.getPmPassword().getEntity());
         host.setPmType((String) model.getPmType().getSelectedItem());
@@ -1157,7 +1157,7 @@
         }
 
         // Set primary PM parameters.
-        model.getManagementIp().setEntity(vds.getManagmentIp());
+        model.getManagementIp().setEntity(vds.getManagementIp());
         model.getPmUserName().setEntity(vds.getPmUser());
         model.getPmPassword().setEntity(vds.getPmPassword());
         model.getPmType().setSelectedItem(vds.getPmType());


--
To view, visit http://gerrit.ovirt.org/11952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieca99ae5bd2eced0a5882a6a6c778370cf16a975
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to