Maor Lipchuk has posted comments on this change.
Change subject: core: fix redundant storage server conn in db
......................................................................
Patch Set 3: (2 inline comments)
no changes needed in REST?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java
Line 45: .RunVdsCommand(
Line 46: VDSCommandType.DisconnectStorageServer,
Line 47: new
ConnectStorageServerVDSCommandParameters(getParameters().getVdsId(),
getParameters()
Line 48: .getStoragePoolId(),
getParameters().getStorageServerConnection().getstorage_type(),
Line 49: new
java.util.ArrayList<StorageServerConnections>(java.util.Arrays
Although it is simply a re-factoring, perhaps we can replace the explicit
package name java.util and simply use import.
Line 50: .asList(new
StorageServerConnections[] { getConnection() })))).getSucceeded() ;
Line 51: }
Line 52:
....................................................
Commit Message
Line 11: The redundant entries entered when AddStorageServerConnectionCommand
Line 12: succeeded, but another command that ran after it failed. Adding a new
Line 13: command that in case of failure deletes the connection from db fixes
the
Line 14: problem.
Line 15: As part of the fix, add assignment of the connection id in UI in
StorageListModel -because otherwise it would not know which connection to
delete.
line should be shorter, to fit the commit message template.
Line 16:
Line 17: Change-Id: Iea5468371514bd2c7bc043a6c5520e2864a09fe8
Line 18: Bug-Url: https://bugzilla.redhat.com/815083
--
To view, visit http://gerrit.ovirt.org/11936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea5468371514bd2c7bc043a6c5520e2864a09fe8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
