Alon Bar-Lev has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java
Line 21:
Line 22:
configBuilder.append(lineSeparator).append("type=spice")//$NON-NLS-1$
Line 23:
.append(lineSeparator).append("host=").append(getHost())//$NON-NLS-1$
Line 24:
.append(lineSeparator).append("password=").append(getPassword())//$NON-NLS-1$
Line 25:
.append(lineSeparator).append("port=").append(Integer.toString(getPort()));//$NON-NLS-1$
Well, any template will do, it happens once in eternity... better to have nice
code than this one... not that I maintain this... but if you don't like
stirng.format then you can still use some template:
config= (
"[virt-viewer]\n" +
"host=@HOST@\n" +
"password=@PASSWORD@\n" +
"..."
).replace(
"@HOST@", getHost()
).replace(
"@PASSWORD@", getPassword()
);
Just a suggestion... :)
Line 26:
Line 27:
ConsoleModel.makeConsoleConfigRequest(configBuilder.toString());
Line 28: }
Line 29:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
Line 277:
Line 278: VerticalPanel innerPanel = new VerticalPanel();
Line 279: innerPanel.add(buildTextArea("filename",
"console.vv"));//$NON-NLS-1$ $NON-NLS-2$
Line 280: innerPanel.add(buildTextArea("contenttype",
"x-virt-viewer"));//$NON-NLS-1$ $NON-NLS-2$
Line 281: innerPanel.add(buildTextArea("content",
configFileContent));//$NON-NLS-1$
One entity should be specified at one place, hence virt-viewer settings should
be at one place.
Line 282:
Line 283: formPanel.setWidget(innerPanel);
Line 284: formPanel.setAction(CONSOLE_CONFIG_SERVLET_URL);
Line 285:
--
To view, visit http://gerrit.ovirt.org/11703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib31e870deb7ecb3dac4cff25e49a3ebca4706a25
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
