Yair Zaslavsky has posted comments on this change.
Change subject: tools : manage-domains messages should be more clear
......................................................................
Patch Set 2: (1 inline comment)
One comment.
In general - I really liked your solution - it is more comprehensive than what
I had in mind - good job!
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsDAOImpl.java
Line 64: if (resultSet.next()) {
Line 65: return true;
Line 66: }
Line 67: } finally {
Line 68: if (resultSet != null) {
Please use the closeQuietly methods at DbUtils
Line 69: resultSet.close();
Line 70: }
Line 71: if (prepareStatement != null) {
Line 72: prepareStatement.close();
--
To view, visit http://gerrit.ovirt.org/11992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf4428a2d59d7bda5f3fa70f4c7334a4a4624c42
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
