Lior Vernia has uploaded a new change for review. Change subject: webadmin: Removed VLAN sorting from Host/Networks subtab ......................................................................
webadmin: Removed VLAN sorting from Host/Networks subtab The sorting was done purely lexicographically, which could be somewhat wrong, and would actually override the proper sorting done now in the host interfaces query. Also, the class HostVLanByNamerComparer is removed since it is no longer needed here and is not used anywhere else. Change-Id: Ib757830b7a07405a380b27bdbd3b9dcb7073eed4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=883269 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVLanByNameComparer.java 2 files changed, 0 insertions(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/11998/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java index 2aff7fd..de2440b 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java @@ -547,9 +547,6 @@ model.getVLans().add(hv); } } - - ArrayList<HostVLan> list = model.getVLans(); - Collections.sort(list, new HostVLanByNameComparer()); } setItems(items); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVLanByNameComparer.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVLanByNameComparer.java deleted file mode 100644 index fc3a1a4..0000000 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVLanByNameComparer.java +++ /dev/null @@ -1,13 +0,0 @@ -package org.ovirt.engine.ui.uicommonweb.models.hosts; - -import java.util.Comparator; - -@SuppressWarnings("unused") -public class HostVLanByNameComparer implements Comparator<HostVLan> -{ - @Override - public int compare(HostVLan x, HostVLan y) - { - return x.getName().compareTo(y.getName()); - } -} -- To view, visit http://gerrit.ovirt.org/11998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib757830b7a07405a380b27bdbd3b9dcb7073eed4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
