Yair Zaslavsky has posted comments on this change.
Change subject: engine: Adding support for lock to survive restart
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1504: }
Line 1505: }
Line 1506:
Line 1507: private void freeLockExecute() {
Line 1508: if (isReleaseExecute || !getSucceeded()) {
Why do we also need to check !getSucceeded ?
Line 1509: freeLock();
Line 1510: }
Line 1511: }
Line 1512:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java
Line 48: }
Line 49:
Line 50: public EntityAsyncTask(AsyncTaskParameters parameters, boolean
duringInit) {
Line 51: super(parameters);
Line 52: boolean isNewCommanAdded = false;
s/isNewCommanAdded/isNewCommandAdded (you forgot the "d" at the end of
"Commnand")
Line 53: synchronized (_lockObject) {
Line 54: if (!_multiTasksByEntities.containsKey(getContainerId())) {
Line 55: log.infoFormat("EntityAsyncTask::Adding
EntityMultiAsyncTasks object for entity '{0}'",
Line 56: getContainerId());
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockIdNameAttribute.java
Line 9: @Retention(RetentionPolicy.RUNTIME)
Line 10: public @interface LockIdNameAttribute {
Line 11: boolean isWait() default false;
Line 12:
Line 13: boolean isReleaseExecute() default true;
Although can be understood from code, I would prefer if you rename this to
isReleaseAtEndOfExecute
--
To view, visit http://gerrit.ovirt.org/11976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c73dac12f6f56ce92a16f94d3b49e0795ab2e46
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
