Vojtech Szocs has posted comments on this change. Change subject: userportal: Fix memory leaks ......................................................................
Patch Set 7: Submitted new patch set, it's now ready for final review. Changes I've made: * revert UiCommandButtonDefinition modification (which impacts WebAdmin) according to Einav's comment in patch set 1, will submit a separate patch for this * common logic for clearing UserPortalItemModel references moved to IUserPortalListModel.clearItemReferences, UserPortalBasicListModel and UserPortalListModel now just call this method within setItems * removed code duplication in MainTabBasicListItemView.addXxxButton methods * reverted some minor whitespace/formatting changes in UiCommon classes -- To view, visit http://gerrit.ovirt.org/11975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ebfd191f59b3ab9841b0cb11c110e50da336263 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
