Moti Asayag has posted comments on this change.
Change subject: engine: add logging for VM NIC link up/down
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
Line 222: getInterface().isLinked() ?
AuditLogType.NETWORK_UPDATE_VM_INTERFACE_LINK_UP
Line 223: :
AuditLogType.NETWORK_UPDATE_VM_INTERFACE_LINK_DOWN;
Line 224: addCustomValue("LinkState",
AuditLogDirector.getMessage(customValue));
Line 225: } else {
Line 226: addCustomValue("LinkState", " ");
Would that result in 2 spaces before the user name in the message?
I think that "" is enough (or StringUtils.EMPTY)
Line 227: }
Line 228: return AuditLogType.NETWORK_UPDATE_VM_INTERFACE;
Line 229: }
Line 230:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 683: EXTERNAL_EVENT_WARNING(9802),
Line 684: EXTERNAL_EVENT_ERROR(9803),
Line 685: EXTERNAL_ALERT(9804),
Line 686:
Line 687: // Vm Network interface update - link state
Please use 1116 and 1117 as the ordinal value and place the new audit-log-type
at the end of the network section within this file (around line 532).
Line 688: NETWORK_UPDATE_VM_INTERFACE_LINK_UP(9901),
Line 689: NETWORK_UPDATE_VM_INTERFACE_LINK_DOWN(9902);
Line 690:
Line 691: private int intValue;
--
To view, visit http://gerrit.ovirt.org/12031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e7d34d8e7c213e4300f9405e90c4fba298f665d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
