Allon Mureinik has uploaded a new change for review.

Change subject: core: AsyncTaskDAO proper newline logging
......................................................................

core: AsyncTaskDAO proper newline logging

Used the %n platform independent newline instead of the platform
specific \n in AsyncTaskDAODbFacadeImpl's logging.

This addresses the VA_FORMAT_STRING_USES_NEWLINE FindBugs warning.

Change-Id: I1bf28f3006b24f121d1c97ac1034f03e62c51d6e
Signed-off-by: Allon Mureinik <[email protected]>
---
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/12112/1

diff --git 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
index 2052f8f..8bcd7dd 100644
--- 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
+++ 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
@@ -158,7 +158,7 @@
             StackTraceElement[] st = Thread.currentThread().getStackTrace();
 
             for (StackTraceElement element : st) {
-                sb.append(String.format("\tMethod: %1$s\n",
+                sb.append(String.format("\tMethod: %1$s%n",
                         element.getMethodName()));
             }
 


--
To view, visit http://gerrit.ovirt.org/12112
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bf28f3006b24f121d1c97ac1034f03e62c51d6e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to