Tal Nisan has posted comments on this change.
Change subject: core: VmPoolCommandBase: Direct domain validation
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
Line 192: if (!spUpResult.isValid()) {
Line 193: return failVmFree(messages,
spUpResult.getMessage().name());
Line 194: }
Line 195:
Line 196: Guid storageDomainId = vmImages.size() > 0 ?
vmImages.get(0).getstorage_ids().get(0) : Guid.Empty;
Isn't it possible to have images on multiple storage domains?
In that case we should validate each of the storage domains
Line 197: if (!Guid.Empty.equals(storageDomainId)) {
Line 198: StorageDomainValidator storageDomainValidator =
Line 199: new StorageDomainValidator(DbFacade.getInstance()
Line 200: .getStorageDomainDao()
--
To view, visit http://gerrit.ovirt.org/12125
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d1854bc4a33f2f7ea218670082dd9bee7467cd9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
