Moti Asayag has posted comments on this change.
Change subject: core: Refactor SetupNetworksVdsCommand
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
Line 45: if (isVlan(network)) {
Line 46: opts.put("vlan", network.getVlanId().toString());
Line 47: }
Line 48:
Line 49: // TODO: add bootproto to network object
the comment could be deleted - at the moment we do not maintain any boot proto
info on network level.
Line 50: addBootProtocol(opts, iface);
Line 51:
Line 52: if (network.getMtu() != 0) {
Line 53: opts.put("mtu", String.valueOf(network.getMtu()));
Line 68: return networks;
Line 69: }
Line 70:
Line 71: private void addBootProtocol(Map<String, String> opts,
VdsNetworkInterface iface) {
Line 72: if (iface.getBootProtocol() != null) {
i'd perform this condition prior to calling this method -
first it adheres the 'for loop' behavior.
second so the user is aware in which cases he should use this method (when
there is a real value to the boot protocol).
Line 73: switch (iface.getBootProtocol()) {
Line 74: case DHCP:
Line 75: opts.put(BOOT_PROTOCOL, DHCP_BOOT_PROTOCOL);
Line 76: break;
Line 69: }
Line 70:
Line 71: private void addBootProtocol(Map<String, String> opts,
VdsNetworkInterface iface) {
Line 72: if (iface.getBootProtocol() != null) {
Line 73: switch (iface.getBootProtocol()) {
please add the default case to the switch block.
Line 74: case DHCP:
Line 75: opts.put(BOOT_PROTOCOL, DHCP_BOOT_PROTOCOL);
Line 76: break;
Line 77: case STATIC_IP:
--
To view, visit http://gerrit.ovirt.org/12059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12d9c601dad77f77808bbec46271ea675509530
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
