Doron Fediuck has posted comments on this change.
Change subject: core: clean up VDSGroup.equals()
......................................................................
Patch Set 1: Looks good to me, approved
Just one comment to this terrific patch. Since we're dealing with cleanups, I'd
love to see one simple method to handle the repetition of-
if (x.a == null) {
if (other.a != null) {
return false;
}
}
else if (! x.a.equals (other.a)) {
return false;
}
--
To view, visit http://gerrit.ovirt.org/12061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1036db064d343ddc70ab49eeefa0e94e6d2b0f2e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
