Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Failed to add VM network interface from User Portal ......................................................................
webadmin: Failed to add VM network interface from User Portal ConfigurationValues.ManagementNetwork doesn't have ConfigAuthType.User. It means user role can't determine this value. The user shouldn't know what is the management network. If the management network can't be determined the default network should be the first network in the list. Change-Id: I77a15bd0d9d290c8f7e2673f0e0039d70f125c1b Bug-Url: https://bugzilla.redhat.com/912005 Signed-off-by: Alona Kaplan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/37/12137/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java index 259c664..3386086 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java @@ -77,7 +77,7 @@ List<Network> networks = (List<Network>) getNetwork().getItems(); networks = networks == null ? new ArrayList<Network>() : networks; for (Network network : networks) { - if (ENGINE_NETWORK_NAME.equals(network.getName())) { + if (ENGINE_NETWORK_NAME != null && ENGINE_NETWORK_NAME.equals(network.getName())) { getNetwork().setSelectedItem(network); return; } -- To view, visit http://gerrit.ovirt.org/12137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I77a15bd0d9d290c8f7e2673f0e0039d70f125c1b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
