Gilad Chaplik has posted comments on this change.
Change subject: core: Fix UpdateVm permissions check for Quota
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 908: public void addQuotaPermissionSubject(List<PermissionSubject>
quotaPermissionList) {
Line 909: // if quota enforcement is not in HARD_ENFORCEMENT the quota
may be null.
Line 910: if (!isInternalExecution() && getStoragePool() != null
Line 911: && getStoragePool().getQuotaEnforcementType() !=
QuotaEnforcementTypeEnum.DISABLED
Line 912: && getStoragePool().getQuotaEnforcementType() !=
QuotaEnforcementTypeEnum.SOFT_ENFORCEMENT) {
agree, so add (&& quota == null)
Line 913:
Line 914: List<QuotaConsumptionParameter> consumptionParameters =
getQuotaConsumptionParameters();
Line 915:
Line 916: if (consumptionParameters != null) {
--
To view, visit http://gerrit.ovirt.org/11418
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib55016efcbed22b003eaddf5c4f8f62aec88928e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
