Noam Slomianko has posted comments on this change.
Change subject: engine: add qouta mode check in consume storage
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 149: }
Line 150: }
Line 151: }
Line 152: if (!hasStorageId){
Line 153: if(quota.getQuotaEnforcementType() ==
QuotaEnforcementTypeEnum.HARD_ENFORCEMENT){
No, if we got here we used quota earlier in the for loop
Line 154: parameters.getCanDoActionMessages()
Line 155:
.add(VdcBllMessages.ACTION_TYPE_FAILED_NO_QUOTA_SET_FOR_DOMAIN.toString());
Line 156: return false;
Line 157: } else {
Line 152: if (!hasStorageId){
Line 153: if(quota.getQuotaEnforcementType() ==
QuotaEnforcementTypeEnum.HARD_ENFORCEMENT){
Line 154: parameters.getCanDoActionMessages()
Line 155:
.add(VdcBllMessages.ACTION_TYPE_FAILED_NO_QUOTA_SET_FOR_DOMAIN.toString());
Line 156: return false;
I know, I find it clearer to leave the else clause in.
Line 157: } else {
Line 158:
auditLogPair.setFirst(AuditLogType.MISSING_QUOTA_STORAGE_PARAMETERS_PERMISSIVE_MODE);
Line 159: }
Line 160: }
--
To view, visit http://gerrit.ovirt.org/12049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21cc59098ede7044ebde1d544e295300d8b40cb7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
