Mike Kolesnik has posted comments on this change.
Change subject: core: Added LexoNumericComparator utility
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LexoNumericComparator.java
Line 29: return 1;
Line 30: }
Line 31:
Line 32: boolean isDigitTurn = false;
Line 33: int begSeq1 = 0, begSeq2 = 0, endSeq1, endSeq2;
Disregard that part of the comment, In Java the default value is only for
non-final class fields.
Line 34:
Line 35: while ((endSeq1 = findEndOfSequence(str1, begSeq1,
isDigitTurn)) != begSeq1) {
Line 36: if ((endSeq2 = findEndOfSequence(str2, begSeq2,
isDigitTurn)) == begSeq2) {
Line 37: return 1; // str1 and str2 have the same prefix but
str1 has an extra sequence => str1 > str2
--
To view, visit http://gerrit.ovirt.org/11996
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c68446ea6f1865a51455a0a359df339bfb15bba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
