Maor Lipchuk has posted comments on this change.
Change subject: core: MigrateVmDisks - get source domain by disk
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
Line 265: }
Line 266:
Line 267: private boolean validateDestStorage(Guid imageId, Guid
destDomainId) {
Line 268: DiskImage diskImage = getDiskImageById(imageId);
Line 269: Guid storagePoolId = diskImage.getStoragePoolId().getValue();
Why not using getStoragePoolId() instead fetching it from the disk
Line 270: StorageDomainValidator validator = getValidator(destDomainId,
storagePoolId);
Line 271:
Line 272: return validate(validator.isDomainExistAndActive()) &&
validate(validator.domainIsValidDestination());
Line 273: }
--
To view, visit http://gerrit.ovirt.org/12147
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifefe823faa8e546eba3e9d34c4b46609085baad8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
