Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup of GetSystemStatisticsQuery
......................................................................
Patch Set 2: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSystemStatisticsQuery.java
Line 45: int activeUsers = getActiveUsersStat();
Line 46:
Line 47: // Storage Domains:
Line 48: int totalStorageDomains = getTotalStorageDomainsStat();
Line 49: int activeStorageDomains = getActiveStorageDomainsStat();
I would actually get rid of this assigns, why not simply put them directly as
map values.
Will make code more shorter readable and efficient
Line 50:
Line 51: res.put(QueryConstants.SYSTEM_STATS_TOTAL_VMS_FIELD, totalVMs);
Line 52: res.put(QueryConstants.SYSTEM_STATS_ACTIVE_VMS_FIELD,
activeVMs);
Line 53: res.put(QueryConstants.SYSTEM_STATS_DOWN_VMS_FIELD, downVMs);
Line 81: StringUtils.join(activeVmStatuses, COMMA_DELIMITER));
Line 82: }
Line 83:
Line 84: private int getTotalHostsStat() {
Line 85: return
DbFacade.getInstance().getSystemStatisticsValue(HOST_ENTITY_NAME);
/s/DbFacade.getInstance()/getDbFacade()
Line 86: }
Line 87:
Line 88: private int getActiveHostsStat() {
Line 89: String[] activeVdsStatuses =
Line 98: (String.valueOf(VDSStatus.Maintenance.getValue())));
Line 99: }
Line 100:
Line 101: private int getTotalUsersStat() {
Line 102: return
DbFacade.getInstance().getSystemStatisticsValue(USER_ENTITY_NAME);
/s/DbFacade.getInstance()/getDbFacade
Line 103: }
Line 104:
Line 105: private int getActiveUsersStat() {
Line 106: return
DbFacade.getInstance().getSystemStatisticsValue(USER_ENTITY_NAME,
Line 102: return
DbFacade.getInstance().getSystemStatisticsValue(USER_ENTITY_NAME);
Line 103: }
Line 104:
Line 105: private int getActiveUsersStat() {
Line 106: return
DbFacade.getInstance().getSystemStatisticsValue(USER_ENTITY_NAME,
/s/DbFacade.getInstance()/getDbFacade
Line 107: USER_ACTIVE_STATUS);
Line 108: }
Line 109:
Line 110: private int getTotalStorageDomainsStat() {
Line 107: USER_ACTIVE_STATUS);
Line 108: }
Line 109:
Line 110: private int getTotalStorageDomainsStat() {
Line 111: return
DbFacade.getInstance().getSystemStatisticsValue(TOTAL_STORAGE_DOMAIN_ENTITY_NAME);
/s/DbFacade.getInstance()/getDbFacade
Line 112: }
Line 113:
Line 114: private int getActiveStorageDomainsStat() {
Line 115: return DbFacade.getInstance()
Line 111: return
DbFacade.getInstance().getSystemStatisticsValue(TOTAL_STORAGE_DOMAIN_ENTITY_NAME);
Line 112: }
Line 113:
Line 114: private int getActiveStorageDomainsStat() {
Line 115: return DbFacade.getInstance()
/s/DbFacade.getInstance()/getDbFacade
Line 116:
.getSystemStatisticsValue(ACTIVE_STORAGE_DOMAIN_ENTITY_NAME,
Line 117:
(String.valueOf(StorageDomainStatus.Active.getValue())));
Line 118: }
Line 119:
--
To view, visit http://gerrit.ovirt.org/12145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb87448c24c6ac32838ae2e381856f478c27ea52
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
