Yair Zaslavsky has posted comments on this change. Change subject: engine: AsyncTask manger part 2 - vms scenario ......................................................................
Patch Set 1: Looks good to me, approved (3 inline comments) .................................................... Commit Message Line 5: CommitDate: 2013-02-18 15:03:42 +0200 Line 6: Line 7: engine: AsyncTask manger part 2 - vms scenario Line 8: Line 9: The following fiix should sol;ve a following paroblem: s/fiix/fix s/sol;ve/solve Line 10: 1. Part of vm scenarious are creating async task with out parent and child task Line 11: tat's why appropriate check should be added to EntityAsyncTask Line 12: 2. Fixing also VdcActionParametersBase accordingly, because of imageParameters are not Line 13: passed to DB Line 6: Line 7: engine: AsyncTask manger part 2 - vms scenario Line 8: Line 9: The following fiix should sol;ve a following paroblem: Line 10: 1. Part of vm scenarious are creating async task with out parent and child task s/scenarious/scenarios Line 11: tat's why appropriate check should be added to EntityAsyncTask Line 12: 2. Fixing also VdcActionParametersBase accordingly, because of imageParameters are not Line 13: passed to DB Line 14: Line 7: engine: AsyncTask manger part 2 - vms scenario Line 8: Line 9: The following fiix should sol;ve a following paroblem: Line 10: 1. Part of vm scenarious are creating async task with out parent and child task Line 11: tat's why appropriate check should be added to EntityAsyncTask s/tat's/thats Line 12: 2. Fixing also VdcActionParametersBase accordingly, because of imageParameters are not Line 13: passed to DB Line 14: Line 15: Change-Id: I43320dfb32a2477308cd881cb7d27c49f3f9f346 -- To view, visit http://gerrit.ovirt.org/12156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43320dfb32a2477308cd881cb7d27c49f3f9f346 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
