Allon Mureinik has uploaded a new change for review.

Change subject: core: Fix test break in LiveMigrateVmDisksCommand
......................................................................

core: Fix test break in LiveMigrateVmDisksCommand

Change-Id Ifefe823faa8e546eba3e9d34c4b46609085baad8 changed the
semantics of how storage domains were validated, which broke the unit
test.

This patch mocks the storage domain ID on the image correctly, so the
test can continue functioning.

Change-Id: I79162cffafcfd385fdced56e23e6e005828c21f9
Signed-off-by: Allon Mureinik <[email protected]>
---
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/12161/1

diff --git 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
index 62f55ac..fe92cf9 100644
--- 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
+++ 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
@@ -186,7 +186,7 @@
         DiskImage diskImage = new DiskImage();
         diskImage.setId(diskImageId);
         diskImage.setStoragePoolId(storagePoolId);
-        diskImage.setStorageIds(new ArrayList<Guid>());
+        diskImage.setStorageIds(new 
ArrayList<Guid>(Arrays.asList(srcStorageId)));
 
         when(diskImageDao.getAncestor(diskImageId)).thenReturn(diskImage);
         when(diskImageDao.get(diskImageId)).thenReturn(diskImage);


--
To view, visit http://gerrit.ovirt.org/12161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79162cffafcfd385fdced56e23e6e005828c21f9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to