Allon Mureinik has uploaded a new change for review. Change subject: core: Remove JBoss specific logging from bll ......................................................................
core: Remove JBoss specific logging from bll Removed the usage of JBoss specific implementation from bll tests' logging configuration and replaced it with standard log4j configuration for better portability and simplicity. Change-Id: I6988196004df741f37ce4971327c005e068cca5b Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/pom.xml M backend/manager/modules/bll/src/test/resources/log4j.xml 2 files changed, 9 insertions(+), 26 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/12168/1 diff --git a/backend/manager/modules/bll/pom.xml b/backend/manager/modules/bll/pom.xml index ad57500..abed5f3 100644 --- a/backend/manager/modules/bll/pom.xml +++ b/backend/manager/modules/bll/pom.xml @@ -101,13 +101,6 @@ </dependency> <dependency> - <groupId>org.jboss.logging</groupId> - <artifactId>jboss-logging-log4j</artifactId> - <version>2.1.0.GA</version> - <scope>test</scope> - </dependency> - - <dependency> <groupId>commons-configuration</groupId> <artifactId>commons-configuration</artifactId> <version>1.6</version> diff --git a/backend/manager/modules/bll/src/test/resources/log4j.xml b/backend/manager/modules/bll/src/test/resources/log4j.xml index ea6c7e8..80f030b 100644 --- a/backend/manager/modules/bll/src/test/resources/log4j.xml +++ b/backend/manager/modules/bll/src/test/resources/log4j.xml @@ -3,8 +3,8 @@ <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/"; debug="false"> <!-- Log levels:DEBUG,INFO,WARN,ERROR,FATAL --> - <appender name="FILE" class="org.jboss.logging.appender.RollingFileAppender"> - <errorHandler class="org.jboss.logging.util.OnlyOnceErrorHandler"/> + <appender name="FILE" class="org.apache.log4j.RollingFileAppender"> + <errorHandler class="org.apache.log4j.helpers.OnlyOnceErrorHandler"/> <param name="File" value="target/server.log"/> <param name="Append" value="true"/> <param name="MaxFileSize" value="10000KB"/> @@ -20,7 +20,7 @@ <!-- ============================== --> <appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender"> - <errorHandler class="org.jboss.logging.util.OnlyOnceErrorHandler"/> + <errorHandler class="org.apache.log4j.helpers.OnlyOnceErrorHandler"/> <param name="Target" value="System.out"/> <param name="Threshold" value="INFO"/> @@ -34,8 +34,8 @@ <!-- oVirt Appender --> <!-- ============================== --> - <appender name="ENGINE_LOG" class="org.jboss.logging.appender.RollingFileAppender"> - <errorHandler class="org.jboss.logging.util.OnlyOnceErrorHandler"/> + <appender name="ENGINE_LOG" class="org.apache.log4j.RollingFileAppender"> + <errorHandler class="org.apache.log4j.helpers.OnlyOnceErrorHandler"/> <param name="File" value="target/engine.log"/> <param name="Append" value="true"/> <param name="MaxFileSize" value="10000KB"/> @@ -50,8 +50,8 @@ <!-- PublicAPI Appender --> <!-- ============================== --> - <appender name="PUBLICAPI_LOG" class="org.jboss.logging.appender.RollingFileAppender"> - <errorHandler class="org.jboss.logging.util.OnlyOnceErrorHandler"/> + <appender name="PUBLICAPI_LOG" class="org.apache.log4j.RollingFileAppender"> + <errorHandler class="org.apache.log4j.helpers.OnlyOnceErrorHandler"/> <param name="File" value="target/soap-api.log"/> <param name="Append" value="true"/> <param name="MaxFileSize" value="10000KB"/> @@ -75,16 +75,6 @@ <!-- Limit the jacorb category to WARN as its INFO is verbose --> <category name="jacorb"> <priority value="WARN"/> - </category> - - <!-- Set the logging level of the JSF implementation that uses - | java.util.logging. The jdk logging levels can be controlled - | through the org.jboss.logging.log4j.JDKLevel class that - | in addition to the standard log4j levels it adds support for - | SEVERE, WARNING, CONFIG, FINE, FINER, FINEST - --> - <category name="javax.enterprise.resource.webcontainer.jsf"> - <priority value="INFO" class="org.jboss.logging.log4j.JDKLevel"/> </category> <!-- Limit the org.jgroups category to WARN as its INFO is verbose --> @@ -240,8 +230,8 @@ <!-- Uncomment the following to redirect the org.jgroups and org.jboss.ha categories to a cluster.log file. - <appender name="CLUSTER" class="org.jboss.logging.appender.RollingFileAppender"> - <errorHandler class="org.jboss.logging.util.OnlyOnceErrorHandler"/> + <appender name="CLUSTER" class="org.apache.log4j.RollingFileAppender"> + <errorHandler class="org.apache.log4j.helpers.OnlyOnceErrorHandler"/> <param name="File" value="${jboss.server.log.dir}/cluster.log"/> <param name="Append" value="false"/> <param name="MaxFileSize" value="500KB"/> -- To view, visit http://gerrit.ovirt.org/12168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6988196004df741f37ce4971327c005e068cca5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
