Tomas Jelinek has posted comments on this change.
Change subject: webadmin,userportal: Show data centers and their clusters based
on configured cluster service
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
just one tiny comment, otherwise the FE looks ok now.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStoragePoolsByClusterServiceParameters.java
Line 2:
Line 3: /**
Line 4: *
Line 5: *
Line 6: */
please remove
Line 7: public class GetStoragePoolsByClusterServiceParameters extends
VdcQueryParametersBase {
Line 8:
Line 9: private static final long serialVersionUID = -4118891133830586523L;
Line 10:
--
To view, visit http://gerrit.ovirt.org/11395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb63c7e2addf525bb527d94694a8dfc752d69154
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
