Michael Kublin has posted comments on this change. Change subject: core : increment pool master version only if there's new master ......................................................................
Patch Set 2: Verified; Looks good to me, approved The code in DeactivateStorageDomainCommand is classical example of bad code and why workarounds are not good. The pool was always updated - even if we want to perform a change. The comments upon it was : update pool in order to increase a version, but because of different workaround version was not update always, so update was done for nothing. Now regards fix, nice job -- To view, visit http://gerrit.ovirt.org/12214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib292802ee2b7feeb95656d492f75dde549350c48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
