Allon Mureinik has uploaded a new change for review. Change subject: core: PropertyInfo method name ......................................................................
core: PropertyInfo method name Changes PropertyInfo' GetValue method to getValue, as per Java conventions. Change-Id: If29777eb963eeba10473ab0e2638ff80561549f9 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 4 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/12259/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java index 164af7a..f53eb4f 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java @@ -19,7 +19,7 @@ return pd.getName(); } - public Object GetValue(Object obj, Object defaultValue) { + public Object getValue(Object obj, Object defaultValue) { Object returnValue = null; try { returnValue = pd.getReadMethod().invoke(obj); diff --git a/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java b/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java index b8cdd59..01cc3fb 100644 --- a/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java +++ b/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java @@ -19,10 +19,10 @@ @Test public void testIt() { PropertyInfo pc = TypeCompat.GetProperty(this.getClass(), "someValue"); - String result = (String) pc.GetValue(this, "JarJar"); + String result = (String) pc.getValue(this, "JarJar"); assertEquals("Standard", "Anakin", result); this.someValue = null; - result = (String) pc.GetValue(this, "JarJar"); + result = (String) pc.getValue(this, "JarJar"); assertEquals("Null Value", "JarJar", result); } diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java index f981a1d..425f1ba 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java @@ -976,7 +976,7 @@ Map<String, String> returnValue = new HashMap<String, String>(logable.getCustomValues()); Class<?> type = AuditLogableBase.class; for (PropertyInfo propertyInfo : TypeCompat.GetProperties(type)) { - Object value = propertyInfo.GetValue(logable, null); + Object value = propertyInfo.getValue(logable, null); String stringValue = value != null ? value.toString() : null; if (!returnValue.containsKey(propertyInfo.getName().toLowerCase())) { returnValue.put(propertyInfo.getName().toLowerCase(), stringValue); diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java index 1924593..025cd53 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java @@ -182,8 +182,8 @@ Class<?> objectType = source.getClass(); List<PropertyInfo> properties = TypeCompat.GetProperties(objectType); for (PropertyInfo property : properties) { - Object sourceValue = property.GetValue(source, null); - Object destinationValue = property.GetValue(destination, null); + Object sourceValue = property.getValue(source, null); + Object destinationValue = property.getValue(destination, null); if (!(property.isPropertyInstanceOf(ValueObjectMap.class)) && property.getCanWrite() && sourceValue != null && !sourceValue.equals(destinationValue) -- To view, visit http://gerrit.ovirt.org/12259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If29777eb963eeba10473ab0e2638ff80561549f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
