Maor Lipchuk has posted comments on this change.
Change subject: core: VmRunHandler: correct check for disk images
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
Line 127: ValidationResult spUpResult = new
StoragePoolValidator(sp).isUp();
Line 128: if (!spUpResult.isValid()) {
Line 129:
message.add(spUpResult.getMessage().name());
Line 130: retValue = false;
Line 131: }
Something here looks funky:
1. Why do we validate the storage pool only if we have disks?
2. performImageChecksForRunningVm calls PerformImagesChecks which already
filter the disks, so why do it twice?
Line 132:
Line 133: if (retValue &&
!performImageChecksForRunningVm(vm, message, runParams, vmImages)) {
Line 134: retValue = false;
Line 135: }
--
To view, visit http://gerrit.ovirt.org/12247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47cf77154a5e46af23a10550884bbd6cdeecb30
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
