Allon Mureinik has posted comments on this change. Change subject: core: JUnit 4 style for PropertyCompatTest ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyCompatTest.java Line 1: package org.ovirt.engine.core.compat; Line 2: Line 3: import static org.junit.Assert.assertEquals; Line 4: import static org.junit.Assert.assertFalse; @Maor - I'm not sure what you mean by this comment. If you mean the order of the imports, see Alissa's answer. if you mean to ask why I even had to import them, note that that test no longer extends junit.framework.TestCase, so we now have to import the static methods directly. Line 5: Line 6: import java.util.Arrays; Line 7: import java.util.HashMap; Line 8: import java.util.HashSet; -- To view, visit http://gerrit.ovirt.org/12256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3ee0866a05301f354e366a046197b465796d1c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
