Allon Mureinik has posted comments on this change. Change subject: packaging: Updated the skipTests instruction for mvn build ......................................................................
Patch Set 1: IMHO, correctness is more important than speed, and I'd advocate running the tests anyway. (on my machine, the difference is circa a minute, which seems negligible to me) But let's put /that/ argument aside. Several modules (e.g., bll, dal) have test-jar dependencies on other, earlier modules (e.g., utils). So if we don't build the test jars, building the later modules will fail in the /dependency resolving/ phase, before even starting the compilation. -- To view, visit http://gerrit.ovirt.org/12275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If506bcdedb064a10675f5f838e75d17e9c0cdcd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
