Roy Golan has posted comments on this change. Change subject: core: create a data structure for all Runtime updates logics ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmRepositoryUpdater.java Line 29: Line 30: Line 31: public class VmRepositoryUpdater { Line 32: Line 33: private VmRepository repo; agree to have something more verbose. how about "repository" since the class name is VmRepository after all Line 34: private VdsManager vdsManager; Line 35: Line 36: private static final Log log = LogFactory.getLog(VmRepositoryUpdater.class); Line 37: -- To view, visit http://gerrit.ovirt.org/12273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I434b1429dfa184f7a8212843ad7ee2c5a196c783 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches