Roy Golan has posted comments on this change.
Change subject: core: refactor - separate VdsUpdateRuntime responsibilities
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 72: import org.ovirt.engine.core.vdsbroker.xmlrpc.XmlRpcStruct;
Line 73:
Line 74: @SuppressWarnings({ "synthetic-access", "unchecked" })
Line 75: public class VdsUpdateRunTimeInfo {
Line 76: private VmRepositoryUpdater vmRepoUpdater;
this is redundant
Line 77: private Map<Guid, VmInternalData> _runningVms;
Line 78: private final Map<Guid, VmDynamic> _vmDynamicToSave = new
HashMap<Guid, VmDynamic>();
Line 79: private final Map<Guid, VmStatistics> _vmStatisticsToSave = new
HashMap<Guid, VmStatistics>();
Line 80: private final Map<Guid, List<VmNetworkInterface>>
_vmInterfaceStatisticsToSave =
--
To view, visit http://gerrit.ovirt.org/12272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If21db9429413dd8578642b9c09418264a0397aba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
