Allon Mureinik has uploaded a new change for review. Change subject: core: Remove vm_last_up_time member from VmDynamic ......................................................................
core: Remove vm_last_up_time member from VmDynamic Removed the private member "vm_last_up_time" from the VmDynamic class. This member was never updated (in fact, there are no methods to modify it!), and never queried (no such methods exists either), and was only used in the equals(Object) and hashCode() methods. Since its value is always null, it's useless to continue holding it. Change-Id: Iab5358b836c3cb7dd351bfeb25f1a197e534c1d1 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/12326/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java index 45443c4..1171e00 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java @@ -13,7 +13,6 @@ private String vm_ip; private String vm_host; private Integer vm_pid; - private java.util.Date vm_last_up_time; private Date lastStartTime; private String guest_cur_user_name; private String console_cur_user_name; @@ -136,10 +135,6 @@ * result + ((lastStartTime == null) ? 0 : lastStartTime.hashCode()); - result = prime - * result - + ((vm_last_up_time == null) ? 0 : vm_last_up_time - .hashCode()); result = prime * result + ((vm_pid == null) ? 0 : vm_pid.hashCode()); return result; @@ -298,11 +293,6 @@ if (other.lastStartTime != null) return false; } else if (!lastStartTime.equals(other.lastStartTime)) - return false; - if (vm_last_up_time == null) { - if (other.vm_last_up_time != null) - return false; - } else if (!vm_last_up_time.equals(other.vm_last_up_time)) return false; if (vm_pid == null) { if (other.vm_pid != null) -- To view, visit http://gerrit.ovirt.org/12326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab5358b836c3cb7dd351bfeb25f1a197e534c1d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
