Allon Mureinik has uploaded a new change for review. Change subject: ui: AsyncDataProvier - remove unused local vars ......................................................................
ui: AsyncDataProvier - remove unused local vars Removed unused local variables from AsyncDataProvider's functions. Change-Id: I63323233803ee08b3242f4a40fab62eeedd53153 Signed-off-by: Allon Mureinik <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 4 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/12357/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java index 0d69f24..e750c63 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java @@ -27,6 +27,7 @@ import org.ovirt.engine.core.common.businessentities.Role; import org.ovirt.engine.core.common.businessentities.ServerCpu; import org.ovirt.engine.core.common.businessentities.Snapshot; +import org.ovirt.engine.core.common.businessentities.StorageDomain; import org.ovirt.engine.core.common.businessentities.StorageDomainType; import org.ovirt.engine.core.common.businessentities.StorageServerConnections; import org.ovirt.engine.core.common.businessentities.StorageType; @@ -43,7 +44,6 @@ import org.ovirt.engine.core.common.businessentities.VolumeFormat; import org.ovirt.engine.core.common.businessentities.VolumeType; import org.ovirt.engine.core.common.businessentities.permissions; -import org.ovirt.engine.core.common.businessentities.StorageDomain; import org.ovirt.engine.core.common.businessentities.storage_pool; import org.ovirt.engine.core.common.businessentities.tags; import org.ovirt.engine.core.common.businessentities.gluster.GlusterVolumeEntity; @@ -2395,10 +2395,6 @@ if (originalInterface.getVlanId() == null) // no vlan: { // Filter out the Interfaces that have child vlan Interfaces - - ArrayList<InterfaceAndIdQueryParameters> parametersList = - new ArrayList<InterfaceAndIdQueryParameters>(); - ArrayList<VdcQueryType> queryTypeList = new ArrayList<VdcQueryType>(); GetAllChildVlanInterfaces(vdsID, ifacesOptions, new IFrontendMultipleQueryAsyncCallback() { @Override @@ -2410,10 +2406,10 @@ for (int i = 0; i < returnValueList.size(); i++) { VdcQueryReturnValue returnValue = returnValueList.get(i); - ArrayList<VdsNetworkInterface> childVlanInterfaces = new ArrayList<VdsNetworkInterface>(); if (returnValue != null && returnValue.getSucceeded() && returnValue.getReturnValue() != null) { - childVlanInterfaces = (ArrayList<VdsNetworkInterface>) (returnValue.getReturnValue()); + ArrayList<VdsNetworkInterface> childVlanInterfaces = + (ArrayList<VdsNetworkInterface>) (returnValue.getReturnValue()); if (childVlanInterfaces.size() == 0) { @@ -2530,9 +2526,7 @@ @Override public Object Convert(Object source, AsyncQuery _asyncQuery) { - ArrayList<VdsNetworkInterface> siblingVlanInterfaces = new ArrayList<VdsNetworkInterface>(); - - siblingVlanInterfaces = (ArrayList<VdsNetworkInterface>) source; + ArrayList<VdsNetworkInterface> siblingVlanInterfaces = (ArrayList<VdsNetworkInterface>) source; if (siblingVlanInterfaces.size() > 0) { -- To view, visit http://gerrit.ovirt.org/12357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I63323233803ee08b3242f4a40fab62eeedd53153 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
