Michael Pasternak has posted comments on this change.
Change subject: restapi: RSDL - snapshots collection in add VM
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 116: vm.disks.clone: xs:boolean
Line 117: vm.tunnel_migration: xs:boolean
Line 118: vm.payloads.payload--COLLECTION: {payload.type:
'xs:string', payload.file.name: 'xs:string', payload.file.content: 'xs:string'}
Line 119: vm.cpu.cpu_tune.vcpu_pin--COLLECTION: {vcpu_pin.vcpu:
'xs:int', vcpu_pin.cpu_set: 'xs:string'}
Line 120: vm.snapshots.snapshot--COLLECTION: {snapshot.id:
'xs:string'}
this should be another signature overload as vm.disks.clone: xs:boolean can't
be in a same context with vm.snapshots.snapshot--COLLECTION: {snapshot.id:
'xs:string'},
e.g clone-disk/s can't be in a same signature with clone-from-snapshot.
Line 121: urlparams: {}
Line 122: headers:
Line 123: Content-Type: {value: application/xml|json, required: true}
Line 124: Correlation-Id: {value: 'any string', required: false}
--
To view, visit http://gerrit.ovirt.org/12261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4baedc4f11d6de65bfcd3b3efd50afabe4f39b9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
