Gilad Chaplik has posted comments on this change.
Change subject: core: simplify businessentity equals() methods [part 2]
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaStorage.java
Line 158: QuotaStorage other = (QuotaStorage) obj;
Line 159: return (ObjectUtils.objectsEqual(quotaId, other.quotaId)
Line 160: && ObjectUtils.objectsEqual(quotaStorageId,
other.quotaStorageId)
Line 161: && ObjectUtils.objectsEqual(storageId,
other.storageId)
Line 162: && ObjectUtils.objectsEqual(storageLimitGigaByte,
other.storageLimitGigaByte));
missing storageLimitGigaByteUsage,
consider adding it.
Line 163: }
Line 164:
Line 165: /**
Line 166: * @return the storageLimitGigaByte
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaVdsGroup.java
Line 211: return (ObjectUtils.objectsEqual(quotaId, other.quotaId)
Line 212: && ObjectUtils.objectsEqual(quotaVdsGroupId,
other.quotaVdsGroupId)
Line 213: && ObjectUtils.objectsEqual(vdsGroupId,
other.vdsGroupId)
Line 214: && ObjectUtils.objectsEqual(virtualCpu,
other.virtualCpu)
Line 215: && ObjectUtils.objectsEqual(memSizeMB,
other.memSizeMB));
missing memSizeMBUsage, virtualCpuUsage; consider adding them
Line 216: }
Line 217:
Line 218: /**
Line 219: * @return the quotaVdsGroupId
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
Line 68: return (ObjectUtils.objectsEqual(id, other.id)
Line 69: && ObjectUtils.objectsEqual(description,
other.description)
Line 70: && readOnly == other.readOnly
Line 71: && ObjectUtils.objectsEqual(name, other.name)
Line 72: && type == other.type);
missing allowsViewingChildren, consider adding it.
Line 73: }
Line 74:
Line 75: public String getdescription() {
Line 76: return this.description;
--
To view, visit http://gerrit.ovirt.org/12343
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I494d81543f001e0c092ef5c9d08f1ded162cac07
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
