Alissa Bonas has posted comments on this change.
Change subject: engine: Version.equals cleanup
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
Line 146: if (obj == null || getClass() != obj.getClass())
Line 147: return false;
Line 148:
Line 149: Version other = (Version) obj;
Line 150: return major == other.major && minor == other.minor &&
revision == other.revision && build == other.build;
I don't see a big benefit in this change. (I'm not gonna block it from entering
either)
For a better readability, I'd extract the expression and assign it to a
separate local variable, and then return the variable.
Line 151: }
Line 152:
Line 153: public static boolean OpEquality(Version v1, Version v2) {
Line 154: if (v1 == null) {
--
To view, visit http://gerrit.ovirt.org/12370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1486f70b5881a8bea1bcfbf2031687c55c07567
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
