Shireesh Anjal has posted comments on this change.
Change subject: engine: Refactor GlusterQueriesCommand Base
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
One minor comment inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java
Line 53: }
Line 54: return vds.getId();
Line 55: }
Line 56:
Line 57: public VDSReturnValue runVdsCommand(VDSCommandType commandType,
VDSParametersBase parameters)
Should this be protected?
Line 58: throws VdcBLLException {
Line 59: VDSReturnValue returnValue =
getBackendResourceManager().RunVdsCommand(commandType, parameters);
Line 60: if (!returnValue.getSucceeded()) {
Line 61: throw new
VdcBLLException(returnValue.getVdsError().getCode(), returnValue.getVdsError()
--
To view, visit http://gerrit.ovirt.org/12398
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If73701b7756de155c4917944ed43517e53f9b4e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
