Doron Fediuck has posted comments on this change.
Change subject: core: Fix quota release for Remove-Template
......................................................................
Patch Set 1: (1 inline comment)
I have a question...
See inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
Line 279:
Line 280: @Override
Line 281: public List<QuotaConsumptionParameter>
getQuotaStorageConsumptionParameters() {
Line 282: List<QuotaConsumptionParameter> list = new
ArrayList<QuotaConsumptionParameter>();
Line 283: fetchImageTemplates();
Since this will now go to the DB regardless of quota mode,
are you sure we do not need to verify it to prevent performance hits?
Line 284: if (imageTemplates != null) {
Line 285: for (DiskImage disk : imageTemplates) {
Line 286: if (disk.getQuotaId() != null &&
!Guid.Empty.equals(disk.getQuotaId())) {
Line 287: list.add(new QuotaStorageConsumptionParameter(
--
To view, visit http://gerrit.ovirt.org/12396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9326bfb81df2cdf1132f693d30014056df5d66
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
