Yair Zaslavsky has posted comments on this change.

Change subject: backend: shorten message for PM test (#909891)
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceStatusReturnValue.java
Line 35: 
Line 36:     @Override
Line 37:     public String toString() {
Line 38:         final String TEST_SUCCEEDED = "Test Succeeded, ";
Line 39:         final String TEST_FAILED = "Test Failed: ";
Don't we want to keep consistency  - either use ":" or use "," at FAILED and 
SUCCEEDED messages?
Line 40: 
Line 41:         return getIsSucceeded() ? TEST_SUCCEEDED + getStatus() : 
TEST_FAILED + getMessage();
Line 42:     }
Line 43: 


--
To view, visit http://gerrit.ovirt.org/12392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d9736c64cffba817fbfea7caa51eb0d8820ec32
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexey Chub <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to