Allon Mureinik has uploaded a new change for review.

Change subject: core: Remove StringCompatTest
......................................................................

core: Remove StringCompatTest

StringCompatTest did not in fact test StringCompat (which was already
removed), but StringHelper's join method.

This method is already thoroughly tested in StringHelperTest, so this
test is redundant and can be removed.

Change-Id: I9fc6ec3759f661e4da54957a2140a4d975cf9546
Signed-off-by: Allon Mureinik <[email protected]>
---
D 
backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/StringCompatTest.java
1 file changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/12423/1

diff --git 
a/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/StringCompatTest.java
 
b/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/StringCompatTest.java
deleted file mode 100644
index a4eaf41..0000000
--- 
a/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/StringCompatTest.java
+++ /dev/null
@@ -1,11 +0,0 @@
-package org.ovirt.engine.core.compat;
-
-import junit.framework.TestCase;
-
-public class StringCompatTest extends TestCase {
-    public void testIt() {
-        String value = "Jar Jar Binks is Cool";
-        String[] parts = value.split(" ");
-        assertEquals(value, StringHelper.join(" ", parts));
-    }
-}


--
To view, visit http://gerrit.ovirt.org/12423
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fc6ec3759f661e4da54957a2140a4d975cf9546
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to