Liron Aravot has posted comments on this change.
Change subject: core: remove read lock of template while creating VM from it
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
Line 37:
Line 38: @Override
Line 39: protected Map<String, Pair<String, String>> getSharedLocks() {
Line 40: Map<String, Pair<String, String>> locks = new HashMap<String,
Pair<String, String>>();
Line 41: Map<String, Pair<String, String>> parentLocks =
super.getSharedLocks();
now you won't acquire exclusive lock the name as before.
Line 42: if (parentLocks != null) {
Line 43: locks.putAll(parentLocks);
Line 44: }
Line 45: locks.put(getVmTemplateId().toString(),
LockMessagesMatchUtil.TEMPLATE);
--
To view, visit http://gerrit.ovirt.org/12407
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b74347110c468b90e75b4dc6470595576f94f4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
