Muli Salem has posted comments on this change.
Change subject: engine: Hot-unplug fails when unplug nic and changing MAC
address.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
Line 85: // HotPlug in the host is called only if the Vm is UP
Line 86: if (hotPlugVmNicRequired(getVm().getStatus())) {
Line 87: VmNetworkInterface nic =
getVmNetworkInterfaceDao().get(getParameters().getNicId());
Line 88: // Old MAC address is used in case the host is not
familiar with the new MAC address
Line 89: if (getParameters().getOldMacAddress() != null) {
Would be better to use if {} else {} here instead of always getting the nic
from the DB.
Line 90: nic.setMacAddress(getParameters().getOldMacAddress());
Line 91: }
Line 92: runVdsCommand(getParameters().getAction().getCommandType(),
Line 93: new VmNicDeviceVDSParameters(getVdsId(),
--
To view, visit http://gerrit.ovirt.org/12459
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I185e5572501ea86443a93f4fdf309e0e05520646
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
