Yair Zaslavsky has posted comments on this change.
Change subject: core: change shared-lock msg of AddVmFromTemplate
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1528: while(iter.hasNext()) {
Line 1529:
result.addAll(Arrays.asList(iter.next().split("(?=\\$)")));
Line 1530: }
Line 1531: return result;
Line 1532: }
Hi,
Correct me if i'm wrong - but, we have 2 instances of commands in the flow you
described. This means they do not share state. The change done by Arik adds
messages on the canDoActionMessages() collection of each one of the commands.
Not sure how you're going to have this mix.
Line 1533:
Line 1534: private EngineLock buildLock() {
Line 1535: EngineLock lock = null;
Line 1536: Map<String, Pair<String, String>> exclusiveLocks =
getExclusiveLocks();
--
To view, visit http://gerrit.ovirt.org/12488
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fcc4d70bd5ca28c87ca7834bf2b699da5140fc5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
