Moti Asayag has posted comments on this change.
Change subject: core: Allow Update of Network on Host
......................................................................
Patch Set 1:
With the suggested solution the following scenario is possible:
When updating the network definition from 'VM network' to 'Non-Vm network' or
the opposite ('VM network' --> 'Non VM network'): the logical network
definition might be an adequate VM network, and the host does have the network
defined on it. However it is not implemented as a VM network (but as a
bridgeless).
So VdsSelector might select a Host which has improper network to run the VM,
and the command will fail on VDSM side while should have blocked on engine
side.when changing network definition from 'VM network' to 'Non-Vm network' or
the opposite: the logical network definition might be eligible as a VM network,
and the host does have the network defined on it, however it is not implemented
as a VM network (but as a bridgeless).
IMO another check should be added to VdsSelector when selecting a host for
running VMs.
--
To view, visit http://gerrit.ovirt.org/12527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If328c80571d404be453a83c6a14396716b678c74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
