Allon Mureinik has uploaded a new change for review. Change subject: core: Singleton row mapper for StoragePoolIsoMap ......................................................................
core: Singleton row mapper for StoragePoolIsoMap Added a singleton row mapper for StoragePoolIsoMapDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I59d62598c4be4c84879364d016d282855428474c Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java 1 file changed, 23 insertions(+), 44 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/70/12570/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java index 402ba45..3370a69 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java @@ -3,36 +3,39 @@ import java.sql.ResultSet; import java.sql.SQLException; import java.util.List; -import org.springframework.jdbc.core.namedparam.MapSqlParameterSource; -import org.springframework.jdbc.core.simple.ParameterizedRowMapper; + import org.ovirt.engine.core.common.businessentities.StorageDomainOwnerType; import org.ovirt.engine.core.common.businessentities.StorageDomainStatus; -import org.ovirt.engine.core.common.businessentities.StoragePoolIsoMapId; import org.ovirt.engine.core.common.businessentities.StoragePoolIsoMap; +import org.ovirt.engine.core.common.businessentities.StoragePoolIsoMapId; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.compat.NGuid; +import org.springframework.jdbc.core.namedparam.MapSqlParameterSource; +import org.springframework.jdbc.core.simple.ParameterizedRowMapper; public class StoragePoolIsoMapDAODbFacadeImpl extends BaseDAODbFacade implements StoragePoolIsoMapDAO { + + private static final class StoragePoolIsoMapRowMapper implements ParameterizedRowMapper<StoragePoolIsoMap> { + public static final StoragePoolIsoMapRowMapper instance = new StoragePoolIsoMapRowMapper(); + + @Override + public StoragePoolIsoMap mapRow(ResultSet rs, int rowNum) throws SQLException { + StoragePoolIsoMap entity = new StoragePoolIsoMap(); + entity.setstorage_id(Guid.createGuidFromString(rs.getString("storage_id"))); + entity.setstorage_pool_id(NGuid.createGuidFromString(rs.getString("storage_pool_id"))); + entity.setstatus(StorageDomainStatus.forValue(rs.getInt("status"))); + entity.setowner(StorageDomainOwnerType.forValue(rs.getInt("owner"))); + return entity; + } + } @Override public StoragePoolIsoMap get(StoragePoolIsoMapId id) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource().addValue("storage_id", id.getStorageId()) .addValue("storage_pool_id", id.getStoragePoolId()); - ParameterizedRowMapper<StoragePoolIsoMap> mapper = new ParameterizedRowMapper<StoragePoolIsoMap>() { - @Override - public StoragePoolIsoMap mapRow(ResultSet rs, int rowNum) throws SQLException { - StoragePoolIsoMap entity = new StoragePoolIsoMap(); - entity.setstorage_id(Guid.createGuidFromString(rs.getString("storage_id"))); - entity.setstorage_pool_id(NGuid.createGuidFromString(rs.getString("storage_pool_id"))); - entity.setstatus(StorageDomainStatus.forValue(rs.getInt("status"))); - entity.setowner(StorageDomainOwnerType.forValue(rs.getInt("owner"))); - return entity; - } - }; - return getCallsHandler().executeRead("Getstorage_pool_iso_mapBystorage_idAndBystorage_pool_id", - mapper, + StoragePoolIsoMapRowMapper.instance, parameterSource); } @@ -66,20 +69,8 @@ public List<StoragePoolIsoMap> getAllForStoragePool(Guid storagePoolId) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource().addValue("storage_id", Guid.Empty) .addValue("storage_pool_id", storagePoolId); - - ParameterizedRowMapper<StoragePoolIsoMap> mapper = new ParameterizedRowMapper<StoragePoolIsoMap>() { - @Override - public StoragePoolIsoMap mapRow(ResultSet rs, int rowNum) throws SQLException { - StoragePoolIsoMap entity = new StoragePoolIsoMap(); - entity.setstorage_id(Guid.createGuidFromString(rs.getString("storage_id"))); - entity.setstorage_pool_id(NGuid.createGuidFromString(rs.getString("storage_pool_id"))); - entity.setstatus(StorageDomainStatus.forValue(rs.getInt("status"))); - entity.setowner(StorageDomainOwnerType.forValue(rs.getInt("owner"))); - return entity; - } - }; - - return getCallsHandler().executeReadList("Getstorage_pool_iso_mapsByBystorage_pool_id", mapper, + return getCallsHandler().executeReadList("Getstorage_pool_iso_mapsByBystorage_pool_id", + StoragePoolIsoMapRowMapper.instance, parameterSource); } @@ -87,20 +78,8 @@ @Override public List<StoragePoolIsoMap> getAllForStorage(Guid isoId) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource().addValue("storage_id", isoId); - - ParameterizedRowMapper<StoragePoolIsoMap> mapper = new ParameterizedRowMapper<StoragePoolIsoMap>() { - @Override - public StoragePoolIsoMap mapRow(ResultSet rs, int rowNum) throws SQLException { - StoragePoolIsoMap entity = new StoragePoolIsoMap(); - entity.setstorage_id(Guid.createGuidFromString(rs.getString("storage_id"))); - entity.setstorage_pool_id(NGuid.createGuidFromString(rs.getString("storage_pool_id"))); - entity.setstatus(StorageDomainStatus.forValue(rs.getInt("status"))); - entity.setowner(StorageDomainOwnerType.forValue(rs.getInt("owner"))); - return entity; - } - }; - - return getCallsHandler().executeReadList("Getstorage_pool_iso_mapsBystorage_id", mapper, + return getCallsHandler().executeReadList("Getstorage_pool_iso_mapsBystorage_id", + StoragePoolIsoMapRowMapper.instance, parameterSource); } -- To view, visit http://gerrit.ovirt.org/12570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I59d62598c4be4c84879364d016d282855428474c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
