Eli Mesika has posted comments on this change. Change subject: core:SPM role should not be granted to Gluster only nodes ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/dbscripts/vds_sp.sql Line 601: BEGIN Line 602: BEGIN Line 603: RETURN QUERY SELECT vds.* Line 604: FROM vds vds, vds_groups vdsgroup Line 605: WHERE (status = 3) AND (storage_pool_id = v_storage_pool_id) AND (vds_spm_priority IS NULL OR vds_spm_priority > (-1)) OR vds_spm_priority > -1 Line 606: AND vds.vds_group_id = vdsgroup.vds_group_id AND vdsgroup.virt_service = true Line 607: ORDER BY vds_spm_priority DESC, RANDOM(); Line 608: END; Line 609: RETURN; Line 603: RETURN QUERY SELECT vds.* Line 604: FROM vds vds, vds_groups vdsgroup Line 605: WHERE (status = 3) AND (storage_pool_id = v_storage_pool_id) AND (vds_spm_priority IS NULL OR vds_spm_priority > (-1)) Line 606: AND vds.vds_group_id = vdsgroup.vds_group_id AND vdsgroup.virt_service = true Line 607: ORDER BY vds_spm_priority DESC, RANDOM(); why sorting by random after the vds_spm_priority ??? Please remove this redundant sorting unless there is a good reason for that (please explain) Line 608: END; Line 609: RETURN; Line 610: END; $procedure$ Line 611: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/12552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6054ba6ad9864798b5d914659f39edaf884e2215 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
