Oved Ourfali has posted comments on this change.

Change subject: tools: Improve engine-config help
......................................................................


Patch Set 7: (2 inline comments)

....................................................
File 
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/IntegerValueHelper.java
Line 59:     }
Line 60: 
Line 61:     @Override
Line 62:     public String getHelpNote(ConfigKey key) {
Line 63:         return getHelpNoteByType(key, "numercial");
s/numercial/numerical
or maybe just say "numeric?"
Line 64:     }
Line 65: 


....................................................
File 
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringMultipleValueHelper.java
Line 44:     }
Line 45: 
Line 46:     @Override
Line 47:     public String getHelpNote(ConfigKey key) {
Line 48:         return getHelpNoteByType(key, "a comma delimited sub 
collection of any of the possible values");
a comma delimited subset of any of the possible values
Line 49:     }
Line 50: 


--
To view, visit http://gerrit.ovirt.org/12508
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I090d52cbc246eb9ffdd985ca6b5aeab6582c8653
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to