Daniel Erez has posted comments on this change.
Change subject: webadmin: sort roles in permissions popup
......................................................................
Patch Set 2: (6 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java
Line 201:
Line 202: protected void populateRoles(ArrayList<Role> roles){
Line 203: Role engineUserRole = null;
Line 204: ArrayList<Role> newRoles = new ArrayList<Role>(roles.size());
Line 205: for (Role r : roles) {
change 'r' to 'role' (or something similar...)
Line 206: // ignore CONSUME_QUOTA_ROLE in UI
Line 207: if
(r.getId().equals(ApplicationGuids.quotaConsumer.asGuid())) {
Line 208: continue;
Line 209: }
Line 216: }
Line 217: }
Line 218:
Line 219: //Sort by name for easier use
Line 220: Collections.sort(newRoles, new Comparator<Role>() {
add a new RoleNameComparer in Linq class instead...
Line 221: @Override
Line 222: public int compare(Role o1, Role o2) {
Line 223: return o1.getname().compareTo(o2.getname());
Line 224: }
Line 223: return o1.getname().compareTo(o2.getname());
Line 224: }
Line 225: });
Line 226:
Line 227: this.getRole().setItems(newRoles);
remove 'this'
Line 228: if(engineUserRole != null){
Line 229: getRole().setSelectedItem(engineUserRole);
Line 230: } else if(newRoles.size() > 0) {
Line 231: getRole().setSelectedItem(newRoles.get(0));
Line 224: }
Line 225: });
Line 226:
Line 227: this.getRole().setItems(newRoles);
Line 228: if(engineUserRole != null){
use formatter
Line 229: getRole().setSelectedItem(engineUserRole);
Line 230: } else if(newRoles.size() > 0) {
Line 231: getRole().setSelectedItem(newRoles.get(0));
Line 232: }
Line 226:
Line 227: this.getRole().setItems(newRoles);
Line 228: if(engineUserRole != null){
Line 229: getRole().setSelectedItem(engineUserRole);
Line 230: } else if(newRoles.size() > 0) {
use formatter
Line 231: getRole().setSelectedItem(newRoles.get(0));
Line 232: }
Line 233: }
Line 234:
Line 227: this.getRole().setItems(newRoles);
Line 228: if(engineUserRole != null){
Line 229: getRole().setSelectedItem(engineUserRole);
Line 230: } else if(newRoles.size() > 0) {
Line 231: getRole().setSelectedItem(newRoles.get(0));
is it a new logic? why is it needed?
Line 232: }
Line 233: }
Line 234:
Line 235: @Override
--
To view, visit http://gerrit.ovirt.org/12586
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5fcbebbe39f32193767d0ba6c928e7db4fc6c1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
