Allon Mureinik has posted comments on this change.
Change subject: core: Add ImagesHandler.filterEditableImageDisks
......................................................................
Patch Set 4: (1 inline comment)
@Vered - see answer inline in
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
Line 89: result = ImagesHandler.filterImageDisks(allDisks, false, true);
Line 90: assertEquals("Wrong number of disks filtered", 1,
result.size());
Line 91: assertTrue("Wrong disks filtered", result.contains(disk2));
Line 92:
Line 93: result = ImagesHandler.filterEditableImageDisks(allDisks);
@Vered - this is in fact a call to [true,true], but I agree, I'll add another
test
Line 94: assertEquals("Wrong number of disks filtered", 1,
result.size());
Line 95: assertTrue("Wrong disks filtered", result.contains(disk2));
Line 96: }
--
To view, visit http://gerrit.ovirt.org/12320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f766309911d27503dbbb80a07fcc776d9068cd2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
